Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate multiple scopes #123

Merged
merged 2 commits into from
Jan 25, 2021
Merged

feat: Validate multiple scopes #123

merged 2 commits into from
Jan 25, 2021

Conversation

pablosichert
Copy link
Contributor

Hey there! Thanks for this cool app.

This PR allows validating multiple scopes, as in accordance with conventional-changelog/commitlint#901.

@pablosichert
Copy link
Contributor Author

Hey @zeke, pinging you to review, as suggested in your status 😄

Copy link
Owner

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a tiny suggestion, but I'm happy to ship this soon.

lib/is-semantic-message.js Outdated Show resolved Hide resolved
Co-authored-by: Zeke Sikelianos <zeke@github.com>
@zeke
Copy link
Owner

zeke commented Jan 25, 2021

Nice! Thanks for your contribution, it should be deployed in the next few minutes. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants