This repository has been archived by the owner on Jul 1, 2020. It is now read-only.
Support new Context API #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overlookmotel
force-pushed
the
support-context-api
branch
from
2bee6eb to
cac19ca
Compare
overlookmotel
force-pushed
the
support-context-api
branch
from
cac19ca to
39eb86d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my first stab at a solution to #2, supporting React's new Context API which is what React Router etc use.
I've succeeded in making it automatic - you don't need to declare the contexts in use. But that comes at the cost of monkey-patching React's
.createContext()method to record all contexts in use. To activate the shim which makes it work, you need to dorequire('react-ssr-error-boundary/server').shim().Alternatively, contexts can be added manually with
require('react-ssr-error-boundary/server').useContext().It needs some tidying up and I'd intend to write more tests, but is this PR something you'd consider merging?