Update to Polkadot v0.9.6 #219

c410-f3r · 2021-07-06T11:20:12Z

No description provided.

lsaether · 2021-07-06T11:27:21Z

primitives/src/constants.rs


 // Prediction Market parameters
 parameter_types! {
-    pub const AdvisoryBond: Balance = 25 * DOLLARS;
+    pub const AdvisoryBond: Balance = 25 * BASE;


Why was this changed? It should stay low for the testnet.

lsaether · 2021-07-06T11:27:28Z

primitives/src/constants.rs

    pub const DisputeBond: Balance = 5 * BASE;
    pub const DisputeFactor: Balance = 2 * BASE;
    pub const DisputePeriod: BlockNumber = BLOCKS_PER_DAY;
    pub const MaxCategories: u16 = 10;
    pub const MaxDisputes: u16 = 6;
    pub const MinCategories: u16 = 2;
-    pub const OracleBond: Balance = 50 * DOLLARS;
+    pub const OracleBond: Balance = 50 * BASE;


Same as above

lsaether · 2021-07-06T11:27:35Z

primitives/src/constants.rs

    pub const PmPalletId: PalletId = PalletId(*b"zge/pred");
    pub const ReportingPeriod: BlockNumber = BLOCKS_PER_DAY;
-    pub const ValidityBond: Balance = 50 * DOLLARS;
+    pub const ValidityBond: Balance = 50 * BASE;


My Bad. Fixed

lsaether · 2021-07-06T11:31:45Z

Needs to bump the spec version

lsaether · 2021-07-06T11:38:35Z

Since RangeInclusive has changed, it needs to be added/ changed in types.json as well. https://doc.rust-lang.org/nightly/src/core/ops/range.rs.html#341-357

Also, since we expose RangeInclusive as an extrinsic argument, any idea how this works on Polkadot-JS Apps or with the JS layer? I guess we use an object like { start: 0, end: 10, exhausted: false } ? Or can we create an array [0, ... 10] ?

c410-f3r · 2021-07-06T12:04:19Z

Since RangeInclusive has changed, it needs to be added/ changed in types.json as well. https://doc.rust-lang.org/nightly/src/core/ops/range.rs.html#341-357

Also, since we expose RangeInclusive as an extrinsic argument, any idea how this works on Polkadot-JS Apps or with the JS layer? I guess we use an object like { start: 0, end: 10, exhausted: false } ? Or can we create an array [0, ... 10] ?

Support for RangeInclusive was added to parity-scale-codec but apps still doesn't know about RangeInclusive. I am reverting back to (u128, u128) for now because changing to RangeInclusive also implicates a migration

lsaether · 2021-07-06T12:05:30Z

Ok, makes sense. Could you make an issue for this change though? since it seems like something that would be reasonable to do in the future but is lower priority.

c410-f3r · 2021-07-06T12:09:25Z

Ok, makes sense. Could you make an issue for this change though? since it seems like something that would be reasonable to do in the future but is lower priority.

Done -> #220

lsaether · 2021-07-06T12:24:22Z

@sea212 Can you do a quick review on this?

sea212 · 2021-07-06T12:34:03Z

@sea212 Can you do a quick review on this?

Sure, I'll take a look at it.

sea212

Looks good to me.
The currency adjustments are also appropriate and the ExistentialDeposit was also adjusted accordingly, therefore nothing really but the names for the magnitudes of currency should change.

sea212 · 2021-07-06T12:49:51Z

primitives/src/constants.rs

-pub const CENTS: Balance = DOLLARS / 100; // 1_000_000
-pub const MILLICENTS: Balance = CENTS / 1000; // 1_000
+pub const CENT: Balance = BASE / 100; // 100_000_000
+pub const MILI: Balance = CENT / 10; //  10_000_000


Just a minor spelling error: Mili -> Milli

sea212 · 2021-07-06T13:22:42Z

scripts/parachain/local.sh

 PARACHAIN_ID=9123
-POLKADOT_BRANCH=release-v0.9.4
+POLKADOT_BRANCH=release-v0.9.7


Should this be v0.9.7?

v0.9.7 because Rococo is probably using this version

But this is the local environment, isn't it? If I understand correctly, we launch the Rococo chain locally "rococo-local". This way or another, I don't mind if it works properly.

The branch version is mirroring a production environment the same way PARACHAIN_CHAIN is battery_station_staging instead of dev.

Changed back to 0.9.6

Thanks for the clarification.

sea212 · 2021-07-06T13:30:30Z

node/src/service/service_parachain.rs

@@ -65,7 +65,7 @@ pub fn new_partial(
        config.transaction_pool.clone(),
        config.role.is_authority().into(),
        config.prometheus_registry(),
-        task_manager.spawn_handle(),
+        task_manager.spawn_essential_handle(),


Does this prevent a client from further operating a tx pool when an error occurs, i.e. the tx pool is shut down (and therefore the client stops operating, at least this service)?

I don't know the difference between an ordinary and an essential task. This code was simply copied and pasted from the 0.9.6 cumulus branch.
https://core.tetcoin.org/rustdocs/v2.0.1/sc_service/struct.TaskManager.html does not state the difference and paritytech/cumulus#496 does not tell why spawn_handle was replaced.
A spawned task is a separated unit of computation (T: Send) that lives with its own context and I don't know if a failed task will prevent the client from further operating a tx pool. If you see https://github.com/paritytech/substrate/blob/4d9f03d3d6d0ceec0708b1a23978feee12f5b0bb/client/service/src/task_manager/mod.rs#L149-L157, then it might be possible that spawn_essential_handle will improve the robustness of the node.

* Update to Polkadot v0.9.6 * Typo * Change branch to 0.9.6 * Rebase

lsaether reviewed Jul 6, 2021

View reviewed changes

c410-f3r force-pushed the caio-release branch from eaa0ef6 to 4d8dedb Compare July 6, 2021 11:37

c410-f3r force-pushed the caio-release branch from 4d8dedb to 7a9ed37 Compare July 6, 2021 12:05

sea212 approved these changes Jul 6, 2021

View reviewed changes

c410-f3r added 4 commits July 6, 2021 14:25

Update to Polkadot v0.9.6

6239228

Typo

24c9a11

Change branch to 0.9.6

b682379

Rebase

7b4c223

c410-f3r force-pushed the caio-release branch from a34dc91 to 7b4c223 Compare July 6, 2021 17:43

lsaether merged commit 7a67a5b into main Jul 6, 2021

lsaether deleted the caio-release branch July 7, 2021 19:14

c410-f3r added a commit to c410-f3r/zeitgeist that referenced this pull request Sep 14, 2021

Update to Polkadot v0.9.6 (zeitgeistpm#219)

96bcc99

* Update to Polkadot v0.9.6 * Typo * Change branch to 0.9.6 * Rebase

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Polkadot v0.9.6 #219

Update to Polkadot v0.9.6 #219

c410-f3r commented Jul 6, 2021

lsaether Jul 6, 2021

lsaether Jul 6, 2021

lsaether Jul 6, 2021

c410-f3r Jul 6, 2021

lsaether commented Jul 6, 2021

lsaether commented Jul 6, 2021 •

edited

Loading

c410-f3r commented Jul 6, 2021

lsaether commented Jul 6, 2021

c410-f3r commented Jul 6, 2021

lsaether commented Jul 6, 2021

sea212 commented Jul 6, 2021

sea212 left a comment

sea212 Jul 6, 2021

sea212 Jul 6, 2021

c410-f3r Jul 6, 2021

sea212 Jul 6, 2021

c410-f3r Jul 6, 2021

sea212 Jul 6, 2021

sea212 Jul 6, 2021

c410-f3r Jul 6, 2021 •

edited

Loading

Update to Polkadot v0.9.6 #219

Update to Polkadot v0.9.6 #219

Conversation

c410-f3r commented Jul 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsaether commented Jul 6, 2021

lsaether commented Jul 6, 2021 • edited Loading

c410-f3r commented Jul 6, 2021

lsaether commented Jul 6, 2021

c410-f3r commented Jul 6, 2021

lsaether commented Jul 6, 2021

sea212 commented Jul 6, 2021

sea212 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c410-f3r Jul 6, 2021 • edited Loading

Choose a reason for hiding this comment

lsaether commented Jul 6, 2021 •

edited

Loading

c410-f3r Jul 6, 2021 •

edited

Loading