Skip to content

Conversation

Chralt98
Copy link
Member

What does it do?

It removes the pallet contracts removal migration and adds a changelog for the developers to inform about the 0.5.7 runtime upgrade change.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:review-needed The pull request requires reviews label Jan 30, 2025
@Chralt98 Chralt98 self-assigned this Jan 30, 2025
@Chralt98 Chralt98 requested a review from sea212 as a code owner January 30, 2025 13:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (940a8d8) to head (012a110).
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   93.19%   93.18%   -0.01%     
==========================================
  Files         131      131              
  Lines       29241    29274      +33     
==========================================
+ Hits        27252    27280      +28     
- Misses       1989     1994       +5     
Flag Coverage Δ
tests 93.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robhyrk
robhyrk previously approved these changes Jan 30, 2025
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Jan 30, 2025
@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:in-progress The pull requests is currently being worked on labels Jan 30, 2025
@Chralt98 Chralt98 added s:blocked The pull requests awaits resolution of dependencies (state what it depends on) and removed s:accepted This pull request is ready for merge labels Feb 10, 2025
@Chralt98
Copy link
Member Author

This PR needs to be merged after the #1398 merge.

@Chralt98 Chralt98 added s:review-needed The pull request requires reviews s:accepted This pull request is ready for merge and removed s:blocked The pull requests awaits resolution of dependencies (state what it depends on) s:review-needed The pull request requires reviews labels Feb 24, 2025
@Chralt98 Chralt98 merged commit 36faa40 into main Feb 24, 2025
48 checks passed
@Chralt98 Chralt98 deleted the chralt98-remove-migrations branch February 24, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants