Skip to content

Conversation

Chralt98
Copy link
Member

What does it do?

This allows the council and technical committee to control decision making when three out of five members of the team are in favor of the decision. One member of the team is generally absent. So, there could be one other member also absent and the rest of the team still has the control of making decisions.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:review-needed The pull request requires reviews label Jan 29, 2025
@Chralt98 Chralt98 self-assigned this Jan 29, 2025
@Chralt98 Chralt98 requested a review from sea212 as a code owner January 29, 2025 11:22
@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Jan 29, 2025
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Jan 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (ca88b16) to head (2230c2c).
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1404      +/-   ##
==========================================
- Coverage   93.19%   93.18%   -0.01%     
==========================================
  Files         131      131              
  Lines       29241    29274      +33     
==========================================
+ Hits        27252    27280      +28     
- Misses       1989     1994       +5     
Flag Coverage Δ
tests 93.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Feb 10, 2025
@Chralt98 Chralt98 merged commit adc9443 into main Feb 10, 2025
32 checks passed
@Chralt98 Chralt98 deleted the chralt98-council-threshold branch February 10, 2025 09:22
Chralt98 added a commit that referenced this pull request Feb 10, 2025
Chralt98 added a commit that referenced this pull request Feb 10, 2025
@Chralt98 Chralt98 restored the chralt98-council-threshold branch February 10, 2025 11:01
@Chralt98 Chralt98 deleted the chralt98-council-threshold branch February 24, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants