Fixed problem with opening color picker when using ChangeDetectionStr… #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you show what an example of a problem instance in which your fix is required? As far as I know, setTimeout is overriden by Angular to already perform a top down change detection, so it seems odd to have to explicitely ask Angular to do it before the setTimeout callback returns. |
|
Here is an example: |
|
When you are using onPush the change detection is not run on timeout so this fix is correct. I will merge this for next release. The only thing I am not sure is that is markForCheck enough or do we really need to call detectChanges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problem with opening color picker when using ChangeDetectionStrategy.OnPush