Closed
Conversation
Contributor
Author
|
@ma2bd Thanks for the quick reply! #39 would also likely solve the issue (and is much more applicable and general so thumbs up for that in any case) though I wonder if there is any data structure that works better with a zero-based field … This reminds me of the Thus, I think that #39 is a better idea, perhaps with an extra doc comment or helped method to explain that all default integer values can be set to 1 to allow non-zero values to be successfully traced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NonZero*is a fundamentally useful datatype in Rust, whichserdemodels as a newtype around the inner numerical type. That makes tracing any datatype that contains anyNonZero*difficult, as the tracer by default always passes zero numeric values, whichNonZero*rejects. While giving example data can solve this issue, it is impractical for deeply nestedNonZero*s.This PR fixes this by checking if the traced integer-looking-value is one of the
NonZero*types. While the test is ... not pretty ..., it should be optimised out during monomorphisation.Test Plan
I'm happy to add a few tests for cases you suggest :)