Merge pull request kubernetes-sigs#874 from CodeLingoBot/rewrite

Fix function comments based on best practices from Effective Go
zeeZ · Mar 12, 2019 · 9a41982 · 9a41982
2 parents a94eab0 + 9a4692e
commit 9a41982
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/resource/resource.go b/pkg/resource/resource.go
@@ -54,7 +54,7 @@ func (r *Resource) Behavior() types.GenerationBehavior {
 	return r.options.Behavior()
 }
 
-// NeedAppendHash checks if the resource need a hash suffix
+// NeedHashSuffix checks if the resource need a hash suffix
 func (r *Resource) NeedHashSuffix() bool {
 	return r.options != nil && r.options.NeedsHashSuffix()
 }

diff --git a/pkg/types/genargs.go b/pkg/types/genargs.go
@@ -47,7 +47,7 @@ func (g *GenArgs) String() string {
 		"}"
 }
 
-// NeedHashSuffix returns true if the hash suffix is needed.
+// NeedsHashSuffix returns true if the hash suffix is needed.
 // It is needed when the two conditions are both met
 //  1) GenArgs is not nil
 //  2) DisableNameSuffixHash in GeneratorOptions is not set to true