Repository navigation
DEN-390: execute web startup through bundled flags2env - #63
Draft
ORESoftware wants to merge 5 commits into
Draft
ORESoftware wants to merge 5 commits into
ORESoftware wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close the executable-contract gap tracked in #61:
.cli-flags.tomlwas already admitted in CI, butserver.rsstill read public runtime settings directly fromstd::env.This draft routes startup through one bundled flags2env boundary before tracing, database, auth, network, or listener effects:
flags2envto immutable runtime revisiond7bad9ea7dfc657653368237e08903514cdca1ec;.cli-flags.tomlthroughBundledFlags2Env;defaults < declared dotenv < process environment < dotenv overrides < argv;std::env::varreads fromserver.rs;--help/--versionexplicit startup intents rather than accidentally booting the listener;dotenv = false,files = []).Regression coverage
The new startup module tests:
server.rsadditionally asserts that it contains no direct process-env reads or legacy dotenv loader and that the binary remains a thin Tokio adapter.Lock provenance
Cargo.lockis not hand-edited or copied from stale #43. A temporary branch-specific workflow runs Cargo against the existing lock, requires the lock to be the only generated change, then executes fmt, locked check/tests, and strict Clippy before committing the Cargo-produced lock candidate. The workflow must be removed before promotion.Merge gate
Keep draft until:
No deployment, database mutation, credential change, or branch-protection change is included.
Tracking: DEN-390; closes implementation scope of #61 when merged.