Repository navigation
fix(DEN-3970): formally verify edge WebSocket handshakes - #42
Merged
Merged
Conversation
Reviewed all nine rescue paths against current main: eight were already identical, and the deployment workflow was a strict predecessor missing the public registry/CDN canaries. Preserve maintenance paths, retry policy, live snapshot/If-Match/KV lease and all five Worker targets while retaining the new checked handshake states, canceled setup deadline, locked runtime, and proof tests. Resolve overlapping additions explicitly; the resulting source tree equals the previously tested 758becf tree. Both histories are retained without rebase or force.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Harden the shared app/user/web Cloudflare origin boundary and add a repository-owned fmctl manifest, finite model, actual-handler trace adapter, and real workerd/TCP WebSocket regressions.
Audited fixes
The added regressions failed before the production patch for stripped headers, escaping transport errors, and a leaked post-handshake timer.
Verification
Scope and production hold
This finite handshake model does not prove authentication, cryptography, distributed reconnect/backpressure, or live deployment. Shared Auth and the origin retain authentication authority. The existing exact-path maintenance policy, snapshot/If-Match/KV lease, route scoping, and deployment canaries are preserved.
Production promotion is not complete: the repository deployment secret is missing, local Cloudflare OAuth lacks required lease/route scopes, and the dd-codex AWS session is expired. No credential, DNS, or cluster mutation was performed. The upstream Quint/Apalache protobuf warning remains separately tracked in DEN-565 and is not suppressed.
Related: DEN-3970; zed-pkg/.github#61. Keep the umbrella issue open after this bounded slice.