Repository navigation
fix(audit): materialize recorded git submodules before client builds - #46
Merged
ORESoftware merged 2 commits intoAug 14, 2026
Merged
ORESoftware merged 2 commits into
ORESoftware merged 2 commits into
Conversation
Contributor
Author
|
Validation update: both existing exact-head PR checks are green on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a shared fleet-audit false-negative at the checkout layer instead of patching downstream clients.
The August 12 fleet run (
31580641419) cloned client repositories without initializing recorded git submodules. Foropto-sync/opto-sync-clients, that made the audited checkout structurally incomplete: Rust and Dart paths under the recordedsyncer.cgitlink were absent, and the Zed package smoke test could not findsyncer.c/core/include/syncer.h.Dependency path
zed-pkg/.github nightly fleet runner -> opto-sync/opto-sync-clients -> syncer.c gitlink -> Rust/Dart bindingsThe client repository records the dependency at a gitlink SHA; the runner was leaving that exact dependency unmaterialized.
Fix
--recurse-submodules;This does not change application code, dependency versions, credentials, or any non-audit runtime.
Validation
Static unit coverage is added in
tools/test_run_clients_batch.py. The repository CI/fleet canary should exercise the actual authenticated recursive checkout before this is promoted.This is intentionally draft until exact-head CI is green and a focused fleet rerun proves the Opto Sync Rust/Dart paths no longer fail because the gitlink is empty.