Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #64765, using
benbrandt/acp-message-updatesas the base rather than the keyed-message PR.Compatibility boundary
Reported status remains authoritative even when content conversion fails. Nonterminal updates preserve an open permission request; terminal status still settles it and resumes sleep prevention as before. The existing failed-tool update/upsert lifecycle tests remain unchanged.
This makes presentation updates atomic, not the whole tool update. Existing error propagation, v1 omission semantics, raw-output fallback, and specialized native diff/terminal updates remain intact. It does not add v2 tri-state APIs, a canonical wire-state store, or protocol negotiation.
Validation
acp_threadtests pass.agent_uitests pass with--test-threads=1.agent_serverstests and five native replay tests pass../script/clippypasses foracp_thread,agent_ui,agent,agent_servers, andacp_tools.Suggested .rules additions
For the ACP-thread crate, proposed for a separate rules change:
Release Notes: