Run Windows shell COM work on OLE thread#58735
Open
Veykril wants to merge 2 commits into
Open
Conversation
File dialogs and shell APIs can block or require COM/OLE initialization. Notably the file dialog change fixes us blocking the main thread while having the dialog open which caused us to record hangs.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
TaskDialogIndirect is modal and blocks until the user responds. Run it on a dedicated OLE-initialized thread so prompts do not stall GPUI's foreground executor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File dialogs and shell APIs can block or require COM/OLE initialization. Notably the file dialog change fixes us blocking the main thread while having the dialog open which caused us to record hangs.
Release Notes: