Support multiple snippets locations per extension#45829
Merged
MrSubidubi merged 2 commits intomainfrom Jan 23, 2026
Merged
Conversation
11 tasks
Comment on lines
+58
to
+63
| pub enum ExtensionSnippets { | ||
| Single(PathBuf), | ||
| Multiple(Vec<PathBuf>), | ||
| } |
Contributor
There was a problem hiding this comment.
Why having a Single and a Multiple when everything could be included in the Vec? Is there any benefit of not using a Vec when there's only a single snippet file?
Member
Author
There was a problem hiding this comment.
Yes, there currently is, and that is backwards compatibility for older Zed versions. We'd keep that for extensions pulished with the old format and they would continue to work in older versions. It still is not optimal, because newer extensions with the new format would not work in older versions but we'd try to load these, so I'll need to think about whether there might be a better approach and/or whether it's worth it to keep that around.
osiewicz
approved these changes
Jan 19, 2026
931285e to
10139af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows extensions to add more than one snippet file whilst keeping it backwards compatible.
Release Notes: