Skip to content

Revert "http_client: Add integrity checks for GitHub binaries using digest checks (#43737)"#44086

Merged
ConradIrwin merged 1 commit intomainfrom
revert-43737
Dec 3, 2025
Merged

Revert "http_client: Add integrity checks for GitHub binaries using digest checks (#43737)"#44086
ConradIrwin merged 1 commit intomainfrom
revert-43737

Conversation

@ConradIrwin
Copy link
Member

This reverts commit 05764e8.

Internally we've seen a much higher incidence of macOS code-signing failing on
the download rust analyzer than we did before this change.

It's unclear why this would be a problem, but we want to try reverting to see if that fixes it.

Release Notes:

  • Reverted a change that seemed to cause problems with code-signing on rust-analyzer

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 3, 2025
@ConradIrwin ConradIrwin merged commit 493cfad into main Dec 3, 2025
24 checks passed
@ConradIrwin ConradIrwin deleted the revert-43737 branch December 3, 2025 18:40
baldwindavid added a commit to baldwindavid/zed that referenced this pull request Dec 4, 2025
* main: (155 commits)
  Add support for git remotes (zed-industries#42819)
  python: Improve sorting order of toolchains to give higher precedence to project-local virtual environments that are within current subproject (zed-industries#44141)
  Use buffer language when formatting with Prettier (zed-industries#43368)
  search: Fix sort order not being maintained in presence of open buffers (zed-industries#44135)
  bedrock: Support global endpoints and new regional endpoints (zed-industries#44103)
  linux: Spawn at least two background threads (zed-industries#44110)
  macos: Add missing file access entitlements (zed-industries#43609)
  Re-colorize the brackets when the theme changes (zed-industries#44130)
  Reduce priority of Windows thread pool work items (zed-industries#44121)
  Update fancy-regex (zed-industries#44120)
  Prefer to disable options over hiding (git panel entry context menu) (zed-industries#44102)
  tab_switcher: Subscribe to workspace events instead of pane events (zed-industries#44101)
  editor: Add active match highlight for buffer and project search (zed-industries#44098)
  Add more preview tab settings and fix janky behavior (zed-industries#43921)
  ai: Add an eval for the inline assistant (zed-industries#43291)
  Fix circular reference issue around PopoverMenu again (zed-industries#44084)
  Run `git2::Repository::find_remote` in the background (zed-industries#44092)
  Improve support for multiple registrations of  `textDocument/diagnostic` (zed-industries#43703)
  Revert "http_client: Add integrity checks for GitHub binaries using digest checks (zed-industries#43737)" (zed-industries#44086)
  editor: Fix blame hover not working when inline git blame is disabled (zed-industries#42992)
  ...
CherryWorm pushed a commit to CherryWorm/zed that referenced this pull request Dec 16, 2025
…igest checks (zed-industries#43737)" (zed-industries#44086)

This reverts commit 05764e8.

Internally we've seen a much higher incidence of macOS code-signing
failing on
the download rust analyzer than we did before this change.

It's unclear why this would be a problem, but we want to try reverting
to see if that fixes it.

Release Notes:

- Reverted a change that seemed to cause problems with code-signing on
rust-analyzer
someone13574 pushed a commit to someone13574/zed that referenced this pull request Dec 16, 2025
…igest checks (zed-industries#43737)" (zed-industries#44086)

This reverts commit 05764e8.

Internally we've seen a much higher incidence of macOS code-signing
failing on
the download rust analyzer than we did before this change.

It's unclear why this would be a problem, but we want to try reverting
to see if that fixes it.

Release Notes:

- Reverted a change that seemed to cause problems with code-signing on
rust-analyzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant