ui: Do not selected an index for the ToggleButtonGroup by default#43751
Closed
bnjjj wants to merge 1 commit intozed-industries:mainfrom
Closed
ui: Do not selected an index for the ToggleButtonGroup by default#43751bnjjj wants to merge 1 commit intozed-industries:mainfrom
ToggleButtonGroup by default#43751bnjjj wants to merge 1 commit intozed-industries:mainfrom
Conversation
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Member
|
Hey @bnjjj, thanks for the PR! I'm curious, what is the scenario you're trying to fix where having an option selected by default isn't desirable? |
ToggleButtonGroup by default
Contributor
Author
|
@danilo-leal in this pr #42819 I have a button to filter by git remotes in branch picker |
Member
|
Gotcha. Given that is just a filter that selects one option, we could use a regular |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToggleButtonGroup: Changed default behavior to not pre-select any button index
selected_indexfield fromusizetoOption<usize>, defaulting toNoneinstead of0Release Notes:
ToggleButtonGroupto not pre-select any button index