Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show release notes locally when showing update notification #18486

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

JosephTLyons
Copy link
Contributor

@JosephTLyons JosephTLyons commented Sep 28, 2024

Closes #17527

I think we are ok to switch to using the local action now. There are a few things we don't support, like media, but we don't include media directly too often, and I think this might help push the community to maybe add support for it. That being said, I updated the markdown coming back from the endpoint to include links to the web version of the release notes, so they can always hop over to that version, if they would like.

Screen.Recording.2024-09-28.at.2.13.16.PM.mov

All forming of the Markdown happens in the endpoint, so if someone with a better eye wants to update this, you can do that here:

https://github.com/zed-industries/zed.dev/blob/0e5923e3e7d1caa8b4bf32d0a7f8999b34dbe64c/src/pages/api/release_notes/v2/%5Bchannel_type%5D/%5Bversion%5D.ts#L50-L62

Release Notes:

  • Changed the view the release notes button in the update toast to trigger the local release notes action.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 28, 2024
@zed-industries-bot
Copy link

Messages
📖

This PR includes links to the following GitHub Issues: #17527
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 2768630

@JosephTLyons JosephTLyons merged commit 1021f0e into main Sep 28, 2024
11 checks passed
@JosephTLyons JosephTLyons deleted the use-local-release-notes-in-release-notes-toast branch September 28, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release notes (in editor)
2 participants