Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Set CREATE_NO_WINDOW for commands #18447

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JunkuiZhang
Copy link
Contributor

@JunkuiZhang JunkuiZhang commented Sep 27, 2024

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 27, 2024
@CharlesChen0823
Copy link
Contributor

CharlesChen0823 commented Sep 28, 2024

I think the best method should be introduce an file name command in util crate, in here, create new_std_command and new_smol_command with set CREATE_NO_WINDOW. we can use the two function everywhere, don't need hacky everywhere.

@JunkuiZhang
Copy link
Contributor Author

I think the best method should be introduce an file name command in util crate, in here, create new_std_command and new_smol_command with set CREATE_NO_WINDOW. we can use the two function everywhere, don't need hacky everywhere.

That's my next move. The idea of this draft PR is that making a quick demo to see if it could fix the issue. If so, then I'm gonna refactor the codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] Multiple open and closed terminals at startup
3 participants