Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use BuildJet Ubuntu 20.04 runners for better glibc compatibility #18442

Merged
merged 17 commits into from
Sep 30, 2024
Merged

ci: Use BuildJet Ubuntu 20.04 runners for better glibc compatibility #18442

merged 17 commits into from
Sep 30, 2024
+56 −9

Conversation

notpeter
Copy link
Member

@notpeter notpeter commented Sep 27, 2024 •
edited
Loading

Use BuildJet Ubuntu 20.04 runners.

  • Linux arm64 unchanged (glibc >= 2.35)
  • Linux x64 glibc requirement becomes to >= 2.31 (from glibc >= 2.35).

Note: Ubuntu 20.04 repo cmake (3.16.3) is normally too old to build Zed, but ubuntu-2004 includes cmake 3.30.3.

Distro glibc Supported EOL
Ubuntu 20.04, Mint 20, Pop!_OS 22.04, Debian 11 2.31 Yes 2025-04-23
Ubuntu 22.04, Mint 21 2.35 Yes 2028-07-20
Debian 12 (Bookworm) 2.36 Yes 2028-06-30
Ubuntu 24.04, Mint 22 2.39 Yes 2034-04-xx
RHEL / Alma / Rocky / Oracle 8.x / Amazon Linux 2 2.28 No 2029-05-31
RHEL / Alma / Rocky / Oracle 9.x / Amazon Linux 2023 2.34 Yes 2032-05-31
Fedora 39 2.38 Yes 2024-11-12
Fedora 40 2.39 Yes 2025-05-13
CentOS 9 Stream 2.34 Yes N/A
openSUSE 15.6 2.38 Yes 2025-12-xx
openSUSE Tumbleweed 2.40 Yes N/A
  • Bold in Support column means supported if this merges
  • EOL is "End of Standard Support / Security Patches" not "Extended Support"

Release Notes:

  • Linux: Support older glibc again (Ubuntu20, Mint20, RHEL9, Amazon 2023, CentOS9)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 27, 2024
@osa1 osa1 mentioned this pull request Sep 27, 2024
Closed
1 task
@notpeter notpeter self-assigned this Sep 27, 2024
@notpeter notpeter changed the title ci: Use Buildjet Ubuntu 20.04 runners ci: Use Buildjet Ubuntu 20.04 runners (better glibc compatability) Sep 27, 2024
@notpeter notpeter mentioned this pull request Sep 28, 2024
Closed
1 task
@notpeter notpeter added the run-bundling Configures PR to run the bundle step label Sep 28, 2024
@notpeter notpeter mentioned this pull request Sep 29, 2024
Merged
@maxdeviant maxdeviant changed the title ci: Use Buildjet Ubuntu 20.04 runners (better glibc compatability) ci: Use BuildJet Ubuntu 20.04 runners for better glibc compatibility Sep 30, 2024
@notpeter notpeter merged commit 432de00 into main Sep 30, 2024
13 checks passed
@notpeter notpeter deleted the ubuntu_2004 branch September 30, 2024 21:02
@notpeter
Copy link
Member Author

I built a clean nightly using this and it appears to be working.

Looks like the 22.04 build version did not have a libpthread.so.0 dependency but the 20.04 does.

Full diff:
https://gist.github.com/notpeter/c720b7e478c2e082bc753fc65b9787e5/revisions?diff=unified&w=

notpeter added a commit that referenced this pull request Oct 1, 2024
@notpeter
ci: Use BuildJet Ubuntu 20.04 runners for better glibc compatibility (#…
21f9ac0 
…18442)

Use BuildJet Ubuntu 20.04 runners.
- Linux arm64 unchanged (glibc >= 2.35)
- Linux x64 glibc requirement becomes to >= 2.31 (from glibc >= 2.35).

Note: Ubuntu 20.04 repo cmake (3.16.3) is normally too old to build Zed, but `ubuntu-2004` [includes cmake
3.30.3](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2004-Readme.md#tools).
notpeter added a commit that referenced this pull request Oct 1, 2024
@notpeter
ci: Use BuildJet Ubuntu 20.04 runners for better glibc compatibility (#…
b34d42a 
…18442)

Use BuildJet Ubuntu 20.04 runners.
- Linux arm64 unchanged (glibc >= 2.35)
- Linux x64 glibc requirement becomes to >= 2.31 (from glibc >= 2.35).

Note: Ubuntu 20.04 repo cmake (3.16.3) is normally too old to build Zed, but `ubuntu-2004` [includes cmake
3.30.3](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2004-Readme.md#tools).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxdeviant maxdeviant Awaiting requested review from maxdeviant

Assignees

@notpeter notpeter

Labels
cla-signed The user has signed the Contributor License Agreement run-bundling Configures PR to run the bundle step
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notpeter