Fix missing tooltips for selected buttons #18435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
schpet
added a commit
to schpet/zed
that referenced
this pull request
Oct 3, 2024
* upstream/main: (33 commits) Fine-tune hunk control spacing (zed-industries#18463) Add tooltip for code actions icon button (zed-industries#18461) More git hunk highlighting fixes (zed-industries#18459) Move git hunk controls to the left side (zed-industries#18460) Capitalize tooltip labels on buffer search (zed-industries#18458) Install cargo-edito without extra features (zed-industries#18457) Fix bugs in diff hunk highlighting (zed-industries#18454) Remove Qwen2 model (zed-industries#18444) vim: Command selection fixes (zed-industries#18424) Add a `get-release-notes-since` script (zed-industries#18445) Fix GoToDefinition changing the viewport unnecessarily (zed-industries#18441) docs: Ollama api_url improvements (zed-industries#18440) Fix missing tooltips for selected buttons (zed-industries#18435) Add missing shortcuts in tooltips (zed-industries#18282) assistant: Fix copy/cut not working when selection is empty (zed-industries#18403) Fix the numeration in line wrap docs (zed-industries#18428) ssh remoting: Show error if opening connection timed out (zed-industries#18401) project: Fix worktree store event missing in remote projects (zed-industries#18376) Fix read timeout for ollama (zed-industries#18417) vim: Support za (zed-industries#18421) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13857. Hiding tooltips for selected buttons prevents tooltips like "Close x dock" from showing up, see #14938 for an example.
The intention of the original PR was to hide the "Show application menu" tooltip, while the context menu is open.
In order to fix this without breaking other UI elements, we track the state of the context menu using
PopoverMenuHandlenow, which allows us to prevent the tooltip from showing up while the context menu is open.Closes #14938
Release Notes: