Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing low_speed_timeout functionality #18310

Closed
wants to merge 2 commits into from
Closed

Implement missing low_speed_timeout functionality #18310

wants to merge 2 commits into from

Conversation

13W
Copy link

@13W 13W commented Sep 24, 2024 •
edited
Loading

Release Notes:

  • Fixed usage of low_speed_timeout_in_seconds configuration parameter that was ignored in ollama stream_chat_completion function

@cla-bot cla-bot
Copy link

cla-bot bot commented Sep 24, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @13W on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@13W
Implement missing low_speed_timeout functionality
a0c21e8 
Signed-off-by: Vladimir Bulyga <zero@13w.me>
@cla-bot cla-bot
Copy link

cla-bot bot commented Sep 24, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @13W on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@13W
Copy link
Author

13W commented Sep 24, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 24, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Sep 24, 2024

The cla-bot has been summoned, and re-checked this pull request!

@notpeter notpeter mentioned this pull request Sep 25, 2024
Open
1 task
@ConradIrwin ConradIrwin mentioned this pull request Sep 27, 2024
Merged
@ConradIrwin
Copy link
Member

Thanks for this! I'm in the process of reducing our dependence on isahc, so I've reimplemented this the new way at #18417

ConradIrwin added a commit that referenced this pull request Sep 27, 2024
@ConradIrwin
Fix read timeout for ollama (#18417)
02d0561 
Supercedes: #18310

Release Notes:

- Fixed `low_speed_timeout_in_seconds` for Ollama
@notpeter notpeter reopened this Sep 27, 2024
@notpeter notpeter changed the base branch from main to v0.155.x September 27, 2024 16:14
@notpeter notpeter closed this Sep 27, 2024
@notpeter notpeter mentioned this pull request Sep 27, 2024
Merged
notpeter added a commit that referenced this pull request Sep 27, 2024
@notpeter @13W
Fix Ollama timeouts broken on Preview (#18449)
ee75909 
Supersedes: #18310
See also: #18304

This PR targets v0.155.x and is a hotfix for Preview.

Signed-off-by: Vladimir Bulyga <zero@13w.me>
Co-authored-by: Vladimir Bulyga <zero@13w.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notpeter notpeter

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@13W @ConradIrwin @notpeter