Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pane: Do not autopin new item created as a neighbour of pinned tab #18072

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

osiewicz
Copy link
Contributor

When I used editor::NewFile or ProjectSearch from a pinned tab, the resulting new tab would be pinned (and the last pinned tab would be pushed off). This PR fixes it by always storing new tabs outside of the pinned area if there's no destination index for the new tab.

Release Notes:

  • Fixed tab bar not preserving pinned tab state when an editor::NewFile action is executed.

When I used editor::NewFile or ProjectSearch from a pinned tab, the resulting new tab would be pinned
(and the last pinned tab would be pushed off). This PR fixes it by always storing new tabs outside of the pinned area if there's no destination index for the new tab.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 19, 2024
@osiewicz osiewicz merged commit d2894ce into main Sep 19, 2024
9 checks passed
@osiewicz osiewicz deleted the pinned-tabs-fix-new-file branch September 19, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant