Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set *_font_fallbacks default to None #16941

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

JunkuiZhang
Copy link
Contributor

@JunkuiZhang JunkuiZhang commented Aug 27, 2024

In the current default.json, *_font_fallbacks=[], which results in the fallbacks value in the Font struct always being Some(...).

This PR introduces the following improvements:

  1. Changed *_font_fallbacks = [] to *_font_fallbacks = null in default.json.
  2. Enhanced the macOS and Windows implementations.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 27, 2024
@JunkuiZhang JunkuiZhang changed the title Fallbacks fix Set *_font_fallbacks default to None Aug 27, 2024
@JunkuiZhang JunkuiZhang marked this pull request as ready for review August 27, 2024 18:35
@mikayla-maki mikayla-maki self-assigned this Aug 29, 2024
@mikayla-maki
Copy link
Member

Thanks!

@mikayla-maki mikayla-maki merged commit 64fa7a5 into zed-industries:main Aug 29, 2024
11 checks passed
@JunkuiZhang JunkuiZhang deleted the fallbacks-fix branch September 2, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants