Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize Cuda files as C++ #16098

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Recognize Cuda files as C++ #16098

merged 1 commit into from
Aug 13, 2024

Conversation

Athishpranav2003
Copy link
Contributor

@Athishpranav2003 Athishpranav2003 commented Aug 12, 2024 •
edited by maxdeviant
Loading

Closes #16070

Release Notes:

  • Added support for recognizing Cude files as C++.

@Athishpranav2003
Add cuda file ext to C++ lsp
6ff6406 
Signed-off-by: Athish Pranav D <athishanna@gmail.com>
@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 12, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @Athishpranav2003 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Athishpranav2003
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 12, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @Athishpranav2003 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 12, 2024

The cla-bot has been summoned, and re-checked this pull request!

@Athishpranav2003
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 12, 2024
@cla-bot cla-bot
Copy link

cla-bot bot commented Aug 12, 2024

The cla-bot has been summoned, and re-checked this pull request!

@zed-industries-bot
Copy link

Warnings
⚠️

This PR includes links to the following GitHub Issues: #16070
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 6ff6406

@maxdeviant maxdeviant changed the title Add cuda file ext to C++ lsp Recognize Cuda files as C++ Aug 12, 2024
@Athishpranav2003
Copy link
Contributor Author

Hi @maxdeviant . Seems like the CI tests are passing(not sure of the skipped ones). Is the PR fine?

@notpeter notpeter merged commit d4761a3 into zed-industries:main Aug 13, 2024
12 checks passed
@notpeter
Copy link
Member

Thanks for your contribution @Athishpranav2003!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++ LSP should recognize .cu and .cuh
3 participants
@Athishpranav2003 @zed-industries-bot @notpeter