vim: Fix panic due to overflow when scrolling #16029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
When setting `"vertical_scroll_margin": 99` or other high values this can lead to a panic that crashes Zed. Co-authored-by: Bennet <bennet@zed.dev>
mrnugget
force-pushed
the
vim-fix-overflow
branch
from
a574f5a
to
343aef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
"vertical_scroll_margin": 99or other high values this can lead to a panic that crashes Zed.Release Notes:
vertical_scroll_marginthat exceeded the number of visible lines on the screen.