vim: Support ranges in command #15985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most requested feature here is "search and replace in visual mode", but as a happy side effect we can now support things like :2,12j to join those lines, and much much more.
cla-bot
bot
added
the
cla-signed
|
Haha, someone's having a good vacation! |
mrnugget
reviewed
Aug 8, 2024
crates/vim/src/command.rs
Outdated
Comment on lines
706
to
731
| // let (name, action) = if query.starts_with('/') || query.starts_with('?') { | ||
| // ( | ||
| // query, | ||
| // FindCommand { | ||
| // query: query[1..].to_string(), | ||
| // backwards: query.starts_with('?'), | ||
| // } | ||
| // .boxed_clone(), | ||
| // ) | ||
| // } else if query.starts_with('%') { | ||
| // ( | ||
| // query, | ||
| // ReplaceCommand { | ||
| // query: query.to_string(), | ||
| // } | ||
| // .boxed_clone(), | ||
| // ) | ||
| // } else if range_regex().is_match(query) { | ||
| // ( | ||
| // query, | ||
| // ReplaceCommand { | ||
| // query: query.to_string(), | ||
| // } | ||
| // .boxed_clone(), | ||
| // ) | ||
| // } else { |
|
Was a fun plane ride over, finally had time to push it up! |
ConradIrwin
force-pushed
the
vim-command-ranges
branch
from
c83a028
to
8d008c5
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9428
Closes #13535
The most requested feature here is "search and replace in visual mode",
but as a happy side effect we can now support things like :2,12j to join
those lines, and much much more.
Release Notes:
:'<,'>from visual mode (#13535).