Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zed.desktop.in to include the MimeType for empty files by default #15623

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

rudolfkastl
Copy link
Contributor

@rudolfkastl rudolfkastl commented Aug 1, 2024

Update zed.desktop.in to include the MimeType for empty files.
Seems to be the default for all "text editors" .desktop files.

Release Notes:

  • Improved MimeType list in XDG .desktop file.

…ult.

Update zed.desktop.in to include the MimeType for empty files.
Copy link

cla-bot bot commented Aug 1, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @rudolfkastl on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@rudolfkastl
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Aug 1, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @rudolfkastl on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

Copy link

cla-bot bot commented Aug 1, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title Update zed.desktop.in to include the MimeType for empty files by defa… Update zed.desktop.in to include the MimeType for empty files by default Aug 1, 2024
@rudolfkastl
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 1, 2024
Copy link

cla-bot bot commented Aug 1, 2024

The cla-bot has been summoned, and re-checked this pull request!

@SomeoneToIgnore
Copy link
Contributor

@jansol , would you mind reviewing this?

Copy link
Contributor

@jansol jansol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I hear about application/x-zerosize but I don't think there is any harm in advertising support for it, and given https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3053 it might be somewhat important on recent GNOME setups.

@SomeoneToIgnore
Copy link
Contributor

Thank you!

@SomeoneToIgnore SomeoneToIgnore merged commit 47eed12 into zed-industries:main Aug 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants