Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Fix crash in Wayland when dragging and dropping a tab not belonging to Zed #14995

Merged

Conversation

CharlesChen0823
Copy link
Contributor

close #14189

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 23, 2024
@CharlesChen0823 CharlesChen0823 changed the title linux: Fixed drag and drop a tab not belong Zed linux: Fixed crashed in wayland when drag and drop a tab not belong Zed Jul 23, 2024
@maxdeviant maxdeviant changed the title linux: Fixed crashed in wayland when drag and drop a tab not belong Zed linux: Fix crash in Wayland when dragging and dropping a tab not belonging to Zed Jul 23, 2024
Copy link
Contributor

@apricotbucket28 apricotbucket28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this seems to make sense. Now that I read the Wayland docs again it states this:

It is also an error to perform this request [finish] after a NULL mime type has been set in wl_data_offer.accept

I guess this also applies when no mime type is accepted?

@ConradIrwin ConradIrwin merged commit eb210ca into zed-industries:main Jul 23, 2024
11 checks passed
@ConradIrwin
Copy link
Member

Thank you!

@CharlesChen0823 CharlesChen0823 deleted the fixed_crash_drag_linux branch July 23, 2024 11:08
CharlesChen0823 added a commit to CharlesChen0823/zed that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zed crashes when dragging another app's tab over its window (Linux/Wayland)
3 participants