Compute git statuses using the bundled git executable, not libgit2 #12444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxbrunsfeld
force-pushed
the
dugite-status
branch
from
a541525
to
a040e12
Compare
maxbrunsfeld
force-pushed
the
dugite-status
branch
from
a040e12
to
dc7bc6e
Compare
@maxbrunsfeld Just curious -- what was the difference in speed, do you remember some examples? And many thanks for making further improvements here -- Zed's speed was one of the main reasons why I started using it ❤️ |
maxbrunsfeld
added a commit
that referenced
this pull request
May 31, 2024
The quest for responsiveness in large git repos continues. This is a follow-up to #12444 Release Notes: - N/A
|
I'm looking forward to see GitoxideLabs/gitoxide#1264 works on zed :)
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that somehow, the
gitexecutable is able to computegit statusmuch more quickly than libgit2, so I've switched our git status logic to usegit. Follow-up to #12266.Release Notes: