Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Delete shortcuts in project panel context menu #12250

Merged
merged 1 commit into from
May 24, 2024

Conversation

SomeoneToIgnore
Copy link
Contributor

Closes #12234 by making both default keymap and the menu Delete action declarations to have the same skip_prompt value.
Trash action got more explicit skip_prompt declarations in this PR, but those were the defaults already, so not changed.

Now, Delete action in the project panel will always show a prompt before removing, both on the keystroke and menu item click.
To note, VSCode does skips prompt for the Trash action, so we might want to change that too (later?), the PR does not alter it.

Release Notes:

  • Shows Delete action binding keys in the project panel context menu (12234)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 24, 2024
@Angelk90
Copy link
Contributor

@SomeoneToIgnore : You can also change the label of:

Vscode:
Screenshot 2024-05-24 alle 18 08 48
Screenshot 2024-05-24 alle 18 09 59

Zed:
Screenshot 2024-05-24 alle 18 09 01
Screenshot 2024-05-24 alle 18 10 07

@SomeoneToIgnore
Copy link
Contributor Author

Do you mean adding the integrated word?
I think it's fine already without.

@SomeoneToIgnore SomeoneToIgnore merged commit df35fd0 into main May 24, 2024
8 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/delete-menu-shortcuts branch May 24, 2024 19:02
@Angelk90
Copy link
Contributor

@SomeoneToIgnore :

  • I would rename Rename to Rename...
  • I would rename Open in Terminal to Open in Integrated Terminal

@SomeoneToIgnore
Copy link
Contributor Author

I would prefer shorter, concise phrases instead, thank you for proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete shortcut macos
2 participants