Preserve untitled files for next time #4985

assayire · 2023-02-28T02:14:52Z

Check for existing issues

Completed

Describe the feature

As a Zed lover, I want Zed to not ask to save/delete untitled files when quitting the app but preserve them as is, and have them available for me to work on next time I open zed.

PS: Feature can be tried out in Sublime Text and couple of other editors.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

porsager · 2024-02-05T07:58:58Z

Very much miss this feature, but one super important thing - if it is added - is absolute certainty that you won't loose content in these "unsaved buffers/documents". Once you start relying on this feature it's an extremely great way to keep notes / snippets, etc, but it needs to be something you can trust. I have 9 year old unsaved content in Sublime, which I'd love to move over, but I don't want to risk loosing them (happened a couple of times in the good old textmate days during an upgrade).

jacksongoode · 2024-03-15T18:34:49Z

Agree, this is without a doubt a feature I can't migrate to Zed from Sublime without.

Parithi · 2024-03-26T21:03:01Z

+1 Looking forward to having this feature on Zed. This is the one that stops me from migrating from VSCode.

ddegner · 2024-04-14T02:40:02Z

Cat sat on my power button and force quit everything. Lost an hour or so of writing.

Hopefully the feature will save me next time.

akano-su · 2024-04-26T04:07:05Z

Just ran into this issue and was very upset. Zed. Please. Since Atom stopped development, I haven't migrated to another text editor but you were SUPPOSED TO BE THE ONE!!

NicolayD · 2024-05-23T10:38:10Z

Chiming in on this - this would allow users to use new tabs for notes. It would be immensely helpful.

ylluminate · 2024-05-26T06:52:16Z

It looks like this is in progress. Any idea of a timetable we'll see this ready? I also think a lot of us are waiting for this to really kick Zed's tires.

selfish · 2024-06-09T16:19:20Z

Chiming in - this is the only thing stopping me from uninstalling Sublime and fully making the switch.

mileusna · 2024-06-13T18:37:06Z

I was just about to raise this issue too. All major editors like VS Code and Sublime preserve unsaved files. Zed should do the same, especially considering its frequent updates that require restarts.

ddegner · 2024-06-15T02:44:22Z

Cat sat on my power button and force quit everything. Lost an hour or so of writing.

Hopefully the feature will save me next time.

Bug fixed. The cat has a new home.

MemeKing · 2024-07-11T02:36:02Z

I would love for this feature to be added. It's more than just a convenience, it's practically a whole lifestyle.

This adds the ability for Zed to restore unsaved buffers on restart. The user is no longer prompted to save/discard/cancel when trying to close a Zed window with dirty buffers in it. Instead those dirty buffers are stored and restored on restart. It does this by saving the contents of dirty buffers to the internal SQLite database in which Zed stores other data too. On restart, if there are dirty buffers in the database, they are restored. On certain events (buffer changed, file saved, ...) Zed will serialize these buffers, throttled to a 100ms, so that we don't overload the machine by saving on every keystroke. When Zed quits, it waits until all the buffers are serialized. ### Current limitations - It does not persist undo-history (right now we don't persist/restore undo-history regardless of dirty buffers or not) - It does not restore buffers in windows without projects/worktrees. Example: if you open a new window with `cmd-shift-n` and type something in a buffer, this will _not_ be stored and you will be asked whether to save/discard on quit. In the future, we want to fix this by also restoring windows without projects/worktrees. ### Demo https://github.com/user-attachments/assets/45c63237-8848-471f-8575-ac05496bba19 ### Related tickets I'm unsure about closing them, without also fixing the 2nd limitation: restoring of worktree-less windows. So let's wait until that. - #4985 - #4683 ### Note on performance - Serializing editing buffer (asynchronously on background thread) with 500k lines takes ~200ms on M3 Max. That's an extreme case and that performance seems acceptable. Release Notes: - Added automatic restoring of unsaved buffers. Zed can now be closed even if there are unsaved changes in buffers. One current limitation is that this only works when having projects open, not single files or empty windows with unsaved buffers. The feature can be turned off by setting `{"session": {"restore_unsaved_buffers": false}}`. --------- Co-authored-by: Bennet <bennet@zed.dev> Co-authored-by: Antonio <antonio@zed.dev>

mrnugget · 2024-07-22T07:51:12Z

A first version of this has been merged: #13546

It'll go into Preview release this week, on Wednesday. Stable release next week, pending any bug fixes or revision.

Please see the constraints in the pull request description that apply to this version.

ddegner · 2024-07-22T21:20:09Z

The cat will be allowed back inside.

FullSizeRender.mov

This adds the ability for Zed to restore multiple windows after restarting. It's now the default behavior. Release Notes: - Added ability to restore all windows that were open when Zed was quit. Previously only the last used workspace was restored. This is now the default behavior. To get back the old behavior, add the following to your settings: `{"restore_on_startup": "last_workspace"}` (Part of [#4985](#4985) and [#4683](#4683)) Demo: https://github.com/user-attachments/assets/57a375ec-0c6a-4724-97c4-3fea8f18bc2d --------- Co-authored-by: Nathan <nathan@zed.dev>

JosephTLyons · 2024-07-24T16:11:55Z

The following PRs have added quite a bit to the workspace serialization story:

There are a few known missing bits here, but I think its best that we close this issue out, in favor of new issues that describe those missing bit, so that we can get a clear understanding of how important these bits are to you all, now that most of the functionality has landed. Here are the new issues (upvote via 👍):

Killer work @mrnugget!

selfish · 2024-07-24T22:10:42Z

Thank you @JosephTLyons!
I understand the decision to close that issue. With that I think it's important to mention that #15098 is actually the main reason this feature is so desired. Open a new buffer, type something in, and just know it won't be lost.

JosephTLyons · 2024-07-24T22:15:40Z

Thank you @JosephTLyons! I understand the decision to close that issue. With that I think it's important to mention that #15098 is actually the main reason this feature is so desired. Open a new buffer, type something in, and just know it won't be lost.

Note that this will work right now (in today's preview release) if you are opening an untitled buffer and there's a worktree in your project panel.

Screen.Recording.2024-07-24.at.6.14.16.PM.mov

The only case in which this doesn't work is if you open up a brand new instance of Zed, one that has no projects in it, and then open a new file. I think we definitely want that, but I think a lot of the headache (80 percent or more) has been addressed by @mrnugget's PRs.

…ustries#14965) This adds the ability for Zed to restore multiple windows after restarting. It's now the default behavior. Release Notes: - Added ability to restore all windows that were open when Zed was quit. Previously only the last used workspace was restored. This is now the default behavior. To get back the old behavior, add the following to your settings: `{"restore_on_startup": "last_workspace"}` (Part of [zed-industries#4985](zed-industries#4985) and [zed-industries#4683](zed-industries#4683)) Demo: https://github.com/user-attachments/assets/57a375ec-0c6a-4724-97c4-3fea8f18bc2d --------- Co-authored-by: Nathan <nathan@zed.dev>

SimbaNinja917 · 2024-09-04T13:58:56Z

I am on Zed Zed 0.150.4 my MBP M1 froze and restarted, and I had an untitled document with very important info, Zed restarted empty. Any chance I can recover it from somewhere?

mrnugget · 2024-09-05T08:15:39Z

I am on Zed Zed 0.150.4 my MBP M1 froze and restarted, and I had an untitled document with very important info, Zed restarted empty. Any chance I can recover it from somewhere?

Was that file in a project-less window? i.e. just a single window with unnamed buffers? Because those aren't persisted yet (see above).

But here's what you can do to check whether it's been saved:

sqlite3 ~/Library/Application\ Support/Zed/db/0-stable/db.sqlite 'select contents from editors where contents is not null;'

(That's on macOS, on Linux the path is different.)

This returns the contents of all files where content has been saved.

SimbaNinja917 · 2024-09-08T09:24:00Z

I am on Zed Zed 0.150.4 my MBP M1 froze and restarted, and I had an untitled document with very important info, Zed restarted empty. Any chance I can recover it from somewhere?

Was that file in a project-less window? i.e. just a single window with unnamed buffers? Because those aren't persisted yet (see above).

But here's what you can do to check whether it's been saved:
sqlite3 ~/Library/Application\ Support/Zed/db/0-stable/db.sqlite 'select contents from editors where contents is not null;'
(That's on macOS, on Linux the path is different.)

This returns the contents of all files where content has been saved.

this returned files saved previously as part of a project.
what i had lost was just an open window not part of a project on which i was taking meeting notes. and then lost it all.

assayire added enhancement [core label] triage Maintainer needs to classify the issue labels Feb 28, 2023

JosephTLyons mentioned this issue Jan 24, 2024

Workspace serialization additions #5869

Closed

7 tasks

JosephTLyons added workspace Feedback for workspace management, layout, interactions, etc serialization Restoration of the editor state after a restart and removed triage Maintainer needs to classify the issue labels Feb 28, 2023

probablykasper mentioned this issue Jun 18, 2023

Remember unsaved changes #4683

Closed

1 task

JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024

JosephTLyons mentioned this issue Jul 24, 2023

workspace: restart command should keep unsaved/untitled documents #6232

Closed

1 task

JosephTLyons mentioned this issue Feb 1, 2024

Clicking "restart to update" should save your changes before restarting #7237

Closed

1 task

porsager mentioned this issue Feb 5, 2024

Restarts should be non-destructive on workspace restore/reload #7371

Open

25 tasks

JosephTLyons added the priority request A request from a stakeholder or influential user label Mar 4, 2024

Moshyfawn mentioned this issue Mar 6, 2024

Save untitled buffers between restarts #8958

Closed

1 task

Moshyfawn mentioned this issue Mar 27, 2024

Restore non-project files after relaunching Zed #9851

Closed

1 task

SomeoneToIgnore mentioned this issue Mar 27, 2024

Avoid close confirmation dialogues for multiple files when one of them is cancelled #9871

Open

1 task

This comment has been minimized.

Sign in to view

mrnugget mentioned this issue Jul 16, 2024

Restore unsaved buffers on restart #13546

Merged

mrnugget mentioned this issue Jul 23, 2024

zed: Add ability to restore last session w/ multiple windows #14965

Merged

JosephTLyons closed this as completed Jul 24, 2024

mrnugget mentioned this issue Jul 31, 2024

Zed window should remember last window size and position when opening single files #5258

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preserve untitled files for next time #4985

Preserve untitled files for next time #4985

assayire commented Feb 28, 2023

porsager commented Feb 5, 2024

jacksongoode commented Mar 15, 2024

Parithi commented Mar 26, 2024

ddegner commented Apr 14, 2024

akano-su commented Apr 26, 2024

NicolayD commented May 23, 2024

ylluminate commented May 26, 2024

This comment has been minimized.

selfish commented Jun 9, 2024

mileusna commented Jun 13, 2024

ddegner commented Jun 15, 2024 •

edited

Loading

MemeKing commented Jul 11, 2024

mrnugget commented Jul 22, 2024

ddegner commented Jul 22, 2024

JosephTLyons commented Jul 24, 2024 •

edited

Loading

selfish commented Jul 24, 2024

JosephTLyons commented Jul 24, 2024

SimbaNinja917 commented Sep 4, 2024

mrnugget commented Sep 5, 2024

SimbaNinja917 commented Sep 8, 2024

Preserve untitled files for next time #4985

Preserve untitled files for next time #4985

Comments

assayire commented Feb 28, 2023

Check for existing issues

Describe the feature

If applicable, add mockups / screenshots to help present your vision of the feature

porsager commented Feb 5, 2024

jacksongoode commented Mar 15, 2024

Parithi commented Mar 26, 2024

ddegner commented Apr 14, 2024

akano-su commented Apr 26, 2024

NicolayD commented May 23, 2024

ylluminate commented May 26, 2024

This comment has been minimized.

selfish commented Jun 9, 2024

mileusna commented Jun 13, 2024

ddegner commented Jun 15, 2024 • edited Loading

MemeKing commented Jul 11, 2024

mrnugget commented Jul 22, 2024

ddegner commented Jul 22, 2024

JosephTLyons commented Jul 24, 2024 • edited Loading

selfish commented Jul 24, 2024

JosephTLyons commented Jul 24, 2024

SimbaNinja917 commented Sep 4, 2024

mrnugget commented Sep 5, 2024

SimbaNinja917 commented Sep 8, 2024

ddegner commented Jun 15, 2024 •

edited

Loading

JosephTLyons commented Jul 24, 2024 •

edited

Loading