Autocomplete for functions omits parenthesises with vtsls language server #18014
Labels
defect
[core label]
javascript
JavaScript programming language support
language server
An umbrella label for all language servers
language
An umbrella label for all programming languages syntax behaviors
regression
A bug that was introduced in a recent release
typescript
TypeScript programming language support
Comments
s3bba
added
admin read
JosephTLyons
added
typescript
|
cc: @mrnugget I was able to reproduce on macOS. |
JosephTLyons
added
regression
mrnugget
added a commit
that referenced
this issue
Sep 24, 2024
This fixes #18014 by fixing the regression that was introduced in #17757. In short: after digging into the `vtsls` code, it looks like it essentially doesn't need any `initialization_options`, it's all workspace configuration, since it tries to use the built-in settings from VS Code. I tested the completions, the inlay hints, the max memory - all of it now works after moving to `workspace_configuration`.
|
Thanks! I can confirm that #18259 has resolved this issue for me. |
mrnugget
added a commit
that referenced
this issue
Sep 24, 2024
) This fixes #18014 by fixing the regression that was introduced in #17757. In short: after digging into the `vtsls` code, it looks like it essentially doesn't need any `initialization_options`, it's all workspace configuration, since it tries to use the built-in settings from VS Code. I tested the completions, the inlay hints, the max memory - all of it now works after moving to `workspace_configuration`. Closes #18014. Release Notes: - Fixed `vtsls` being initialized the wrong way, which would mean the wrong options were used to enable completions or inlay hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check for existing issues
Describe the bug / provide steps to reproduce it
This PR has introduced inconsistent behavior across language servers for JS/TS projects.
Using
vtslsserver functions no longer get completed with parenthesises and function argument. Eg.:variable.functionNameWhile if
typescript-language-serveris used we get expected behavior. Eg.:variable.functionName(args)The first commit that has this issue is
02d5f320ad621e92cafaa7075f61e6496e12cd98Environment
Zed: v0.154.0 (Zed Dev 2699fa8)
OS: Linux X11 arch unknown
Memory: 23.5 GiB
Architecture: x86_64
GPU: AMD Radeon VII (RADV VEGA20) || radv || Mesa 24.2.2-arch1.1
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your Zed.log file to this issue.
No response
The text was updated successfully, but these errors were encountered: