Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hint/predictive theme stylings have no effect #17392

Open
1 task done
AlbertMarashi opened this issue Sep 5, 2024 · 0 comments
Open
1 task done

hint/predictive theme stylings have no effect #17392

AlbertMarashi opened this issue Sep 5, 2024 · 0 comments
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@AlbertMarashi
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

image

As you can see, inlay hints and hint syntax node backgrounds have no effect in the editor.

    "experimental.theme_overrides": {
        "hint.foreground": "#F00",
        "hint.background": "#F00",        
        "syntax": {
            "hint": {
                "foreground": "#F00",
                "background": "#F00"
            }
        }
    },

Environment

Zed: v0.151.1 (Zed)
OS: macOS 14.2.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @AlbertMarashi
AlbertMarashi




            added
      

  admin read

  Pending admin review

      

  defect

  [core label]

      

  triage

  Maintainer needs to classify the issue

  labels


      Sep 5, 2024

    

  



    

    

      
    

    


      

          @AlbertMarashi
AlbertMarashi




        changed the title
hint theme stylings have no effect

hint/predictive theme stylings have no effect


      Sep 9, 2024

    

  



  

  

    
  


  

      

    @AlbertMarashi
AlbertMarashi



    mentioned this issue
    
      Sep 9, 2024
    





  


  

      
   Closed

  







  




    

    

      
    

    


      

          @Moshyfawn
Moshyfawn




            added
      

  theme

  Feedback for theme configuration, accessibility, visual issues, etc

      

  editor

  Feedback for code editing, formatting, editor iterations, etc

    and removed
      

  triage

  Maintainer needs to classify the issue

  labels


      Sep 10, 2024

    

  



  

  

    
  


  

      

    @maxdeviant
maxdeviant



    mentioned this issue
    
      Sep 17, 2024
    





  


  

      
   Closed

  







  




    

    

      
    

    


      

          @JosephTLyons
JosephTLyons




          removed
  the 

  admin read

  Pending admin review
 label


      Sep 17, 2024

    

  



  

  

    
  


  

      

    @maxdeviant
maxdeviant



    mentioned this issue
    
      Sep 18, 2024
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  maxdeviant 

      added a commit
      that referenced
      this issue

    
      Sep 18, 2024
    
    

      


  

    

      


  

      
        @maxdeviant
  





      

        
          Add ability to display backgrounds for inlay hints (#18010)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          373a17a
        
      

    

  

    

      
This PR adds the ability to display backgrounds for inlay hints within
the editor.

This is controlled by the new `inlay_hints.show_background` setting.
This setting defaults to `false`.

To enable the setting, add the following to your `settings.json`:

```json
{
  "inlay_hints": {
    "enabled": true,
    "show_background": true
  }
}
```

When enabled, the inlay hint backgrounds will use the `hint.background`
color from the theme.

| Disabled | Enabled |
|
--------------------------------------------------------------------------------------------------------------------------------------------------
|
--------------------------------------------------------------------------------------------------------------------------------------------------
|
| <img width="1624" alt="Screenshot 2024-09-17 at 4 21 53 PM"
src="https://github.com/user-attachments/assets/5534d09b-1e22-4c6f-9d82-314796ed7d22">
| <img width="1624" alt="Screenshot 2024-09-17 at 4 21 43 PM"
src="https://github.com/user-attachments/assets/6ec58cde-6115-4db4-be95-97c5f2f54b2d">
|

Related issues:

- #12485
- #17392

Release Notes:

- Added an `inlay_hints.show_background` setting to allow displaying
backgrounds for inlay hints in the editor.
  - This setting defaults to `false`.
- If enabled, the inlay hint backgrounds will use the `hint.background`
color from the theme.

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    defect

  [core label]
  

    editor

  Feedback for code editing, formatting, editor iterations, etc
  

    theme

  Feedback for theme configuration, accessibility, visual issues, etc








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  



        
      

    

  
      

  

    

      3 participants
    

    

        
          @Moshyfawn 
        
          @AlbertMarashi 
        
          @JosephTLyons