-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue "Go to definition" no longer works #16469
Comments
Note in the video the first window is a React example and second is the broken experience in Vue. |
related to this issue #14723 |
That's funny because autocomplete works me. 🤷🏼♂️ |
I think you can provide the logs. I suspect that you may have installed other plugins? |
@amir20 I have also reproduced this issue and found that it seems to be caused by tailwindcss lsp(maybbbbe?) {
// disable tailwindcss
"language_servers": ["!eslint", "!typescript-language-server", "!tailwindcss-language-server", "..."],
} Screen.Recording.2024-08-20.at.01.30.08.mov |
Confirmed. Is this related to #14723? It doesn't seem like it. |
I downgraded back to 1.147.2 and go to/code navigation started working again. I also disabled auto updating as I lost half a day due to this |
Yea I think I misspoke. Even with tailwind disabled I see this happening. I am wondering if some extension got auto updated. I also lost a lot of time. Going back to Vscode for a while. |
Disabling the Tailwind extension with |
I don't even have the Tailwind extension, so it doesn't work even with |
@danulqua Try adding the three dots at the end |
Downgrading worked for me, too. Setting |
@icarusgk didn't work. Go to definition doesn't work at all everywhere, in |
I have something that looks like a fix, waiting for the review/confirmation: #16654 Meanwhile, using "languages": {
"Vue.js": {
// this is a new line
"language_servers": ["vue-language-server", "..."],
"prettier": {
"allowed": true
}
},
} could help as a workaround. |
Thank you @SomeoneToIgnore, That works! 🚀 |
… their languages (#16654) Follow-up of #15624 Fixes #13769 Fixes #16469 This way, those are considered "primary" and serve all LSP requests like go to definition. Before, Tailwind language server was first and returned nothing for all LSP requests. - Fixed Vue and Svelte languages integrations not handling LSP requests properly ([#13769](#13769)) ([#16469](#16469))
… their languages (#16654) Follow-up of #15624 Fixes #13769 Fixes #16469 This way, those are considered "primary" and serve all LSP requests like go to definition. Before, Tailwind language server was first and returned nothing for all LSP requests. - Fixed Vue and Svelte languages integrations not handling LSP requests properly ([#13769](#13769)) ([#16469](#16469))
… their languages (#16654) Follow-up of #15624 Fixes #13769 Fixes #16469 This way, those are considered "primary" and serve all LSP requests like go to definition. Before, Tailwind language server was first and returned nothing for all LSP requests. - Fixed Vue and Svelte languages integrations not handling LSP requests properly ([#13769](#13769)) ([#16469](#16469))
… their languages (#16654) Follow-up of #15624 Fixes #13769 Fixes #16469 This way, those are considered "primary" and serve all LSP requests like go to definition. Before, Tailwind language server was first and returned nothing for all LSP requests. - Fixed Vue and Svelte languages integrations not handling LSP requests properly ([#13769](#13769)) ([#16469](#16469))
Thank you @SomeoneToIgnore for the great work. |
Hello, same thing with Astro. Used: "languages": {
"Astro": {
"language_servers": ["astro-language-server"]
},
...
} |
Astro seems to have a single language server supported, so this seems a bit unrelated: the current workaround forces a certain, primary, language server to be used first, e.g. : "language_servers": ["vue-language-server", "..."], which is not applicable to a single entry, really. |
I understand, but the "go to definition" doesn't work in astro files (at least on my end) without explicitly setting that up. |
Check for existing issues
Describe the bug / provide steps to reproduce it
I thought I was doing something wrong, but started recently. Zed's
command+click
or right click togo to definition
no longer works in Vue files.I have tested with a brand new project with
pnpm create vite
and then use Vue as template.Note that react using
pnpm create vite
still works.Environment
Zed: v0.148.1 (Zed)
OS: macOS 14.6.1
Memory: 16 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
Zed.mp4
If applicable, attach your Zed.log file to this issue.
Zed.log
The text was updated successfully, but these errors were encountered: