Skip to content

Commit

Permalink
docs: Switch proxy example to socks5h not socks5 (#18142)
Browse files Browse the repository at this point in the history
Very rarely when you have a SOCKS proxy configured do you want local DNS.
`socks5` does local DNS. `socks5h` does remote DNS.
  • Loading branch information
notpeter authored Sep 20, 2024
1 parent 759646e commit f8195c4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion assets/settings/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@
// environment variables.
//
// Examples:
// - "proxy": "socks5://localhost:10808"
// - "proxy": "socks5h://localhost:10808"
// - "proxy": "http://127.0.0.1:10809"
"proxy": null,
// Set to configure aliases for the command palette.
Expand Down
10 changes: 5 additions & 5 deletions docs/src/configuring-zed.md
Original file line number Diff line number Diff line change
Expand Up @@ -1127,10 +1127,10 @@ The following URI schemes are supported:

- `http`
- `https`
- `socks4`
- `socks4a`
- `socks5`
- `socks5h`
- `socks4` - SOCKS4 proxy with local DNS
- `socks4a` - SOCKS4 proxy with remote DNS
- `socks5` - SOCKS5 proxy with local DNS
- `socks5h` - SOCKS5 proxy with remote DNS

`http` will be used when no scheme is specified.

Expand All @@ -1148,7 +1148,7 @@ Or to set a `socks5` proxy:

```json
{
"proxy": "socks5://localhost:10808"
"proxy": "socks5h://localhost:10808"
}
```

Expand Down

0 comments on commit f8195c4

Please sign in to comment.