Update matlab to v0.1.0#3704
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @watermarkhu on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
- Updated submodule branch tracking from master to main - Updated to v0.2.1-1-ga785a2d
|
Sorry for the delay here and thank you for looking into/digging this! We do occasionally move extensions from one owner to another, but it is always a bit awkward to take ownership from someone in that regard, here the maintainer from the old extension. Hence my question would be: Would it be fine for you if we were to move your "new" and obviously more maintained extension into the Would you be down for this? Happy to answer any question you have regarding this. |
There was a problem hiding this comment.
Pull request overview
This PR updates the MATLAB extension to version 0.2.1 and switches to a different implementation that uses a more actively maintained tree-sitter parser and adds MATLAB language server support.
Key Changes
- Updated MATLAB extension submodule to point to a new repository (watermarkhu/zed-matlab)
- Bumped version from 0.0.1 to 0.2.1
- Added branch specification for the submodule
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| extensions/matlab | Updated submodule commit hash to point to new repository |
| extensions.toml | Bumped MATLAB extension version to 0.2.1 |
| .gitmodules | Changed submodule URL to watermarkhu/zed-matlab and added branch specification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @MrSubidubi, I don't mind at all. Just let me know what is needed :) |
|
Alright, thanks! First off, you'll need to transfer the repository to me so that i can move it into the |
|
Done! |
|
Okay so we are done! 🥳 Thank you for being that cooperative! I went on a quick rampage within the repository to align it with how we do some stuff generally in the org. If you disagree with some stuff, we can definitely look at that and/or revert it, e.g. I removed the code owner stuff because we generally do not have it but can definitely put it up for debate. If you use it and feel like it, feel free to add me on Discord (@MrSubidubi ) where I'll happily answer all questions asked, but I'll also get back to you on GitHub. Lastly, once I merge zed-extensions/matlab#16, the bot will create an automated version bump for you on every change to the repo and create an upstream bump once you merge the bot version bump in the repo. We'll take a look and then merge that. Thanks again and if you have any questions, please ask! |
|
And you should already have acces, if you don't have it, please let me know! |
|
@MrSubidubi Thanks for integrating it. It all looks good to me :) I'll reach out if I encounter anything |
@rzukic I was already finished with my extension until I found out about yours. Do you mind?
My extension uses the more maintained https://github.com/acristoffers/tree-sitter-matlab in stead of https://github.com/mstanciu552/tree-sitter-matlab, which is also in use by https://github.com/mathworks/Emacs-MATLAB-Mode.
Also, my extension has support for https://github.com/mathworks/MATLAB-language-server