-
Notifications
You must be signed in to change notification settings - Fork 17
Add --stdio argument to Expert by default
#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --stdio argument to Expert by default
#45
Conversation
MrSubidubi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Two minor things:
- Could we change this to
unwrap_or_elseinstead and change the type ofargsonExpertBinaryto justVec<String>(instead of the currentOption<Vec<String>>? - We usually do not fiddle with the arguments passed by users - if they set the arguments in their settings, we assume they know what they are doing and not change anything about what was passed (eventually we should have this probably, but we can currently not raise visibility for such things). Could we just pass them as-is without modifying these?
|
@MrSubidubi done :) Thank you for the feedback! If the user provides no arguments, we set them default to |
--stdio argument to Expert by default
MrSubidubi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the quick follow-up and congratulations to your first contribution! 🎉
|
Whoohoo! Thank you very much :) |
This PR bumps the version of the Elixir extension to 0.2.4. Includes: - zed-extensions/elixir#38 - zed-extensions/elixir#44 - zed-extensions/elixir#45 - zed-extensions/elixir#48
Closes #41