Skip to content

Conversation

@PJUllrich
Copy link
Contributor

Closes #41

@cla-bot cla-bot bot added the cla-signed label Nov 12, 2025
@PJUllrich PJUllrich changed the title Add --stdio argument if non existent Add --stdio argument to Expert by default Nov 12, 2025
Copy link
Contributor

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Two minor things:

  • Could we change this to unwrap_or_else instead and change the type of args on ExpertBinary to just Vec<String> (instead of the current Option<Vec<String>>?
  • We usually do not fiddle with the arguments passed by users - if they set the arguments in their settings, we assume they know what they are doing and not change anything about what was passed (eventually we should have this probably, but we can currently not raise visibility for such things). Could we just pass them as-is without modifying these?

@PJUllrich
Copy link
Contributor Author

PJUllrich commented Nov 12, 2025

@MrSubidubi done :) Thank you for the feedback!

If the user provides no arguments, we set them default to ["--stdio"] for the Expert language server:

* Binary: LanguageServerBinary {
    path: "~/Library/Application Support/Zed/extensions/work/elixir/expert-nightly/expert",
    arguments: [
        "--stdio",
    ],

@MrSubidubi MrSubidubi changed the title Add --stdio argument to Expert by default Add --stdio argument to Expert by default Nov 12, 2025
Copy link
Contributor

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the quick follow-up and congratulations to your first contribution! 🎉

@MrSubidubi MrSubidubi merged commit 40f5ddf into zed-extensions:main Nov 12, 2025
1 check passed
@PJUllrich
Copy link
Contributor Author

Whoohoo! Thank you very much :)

@PJUllrich PJUllrich deleted the add-stdio-flag-to-expert-by-default branch November 12, 2025 12:35
@MrSubidubi MrSubidubi mentioned this pull request Nov 17, 2025
MrSubidubi added a commit that referenced this pull request Nov 17, 2025
@MrSubidubi MrSubidubi mentioned this pull request Nov 17, 2025
MrSubidubi added a commit that referenced this pull request Nov 17, 2025
MrSubidubi added a commit to zed-industries/extensions that referenced this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expert requires --stdio flag

2 participants