Download nightly builds to checksum-based folder instead of version-based #43
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @PJUllrich on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @PJUllrich on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Just as an FYI: instead of pulling in the SHA2 dependency, we could also take the checksum from the expert_checksums.txt file but that'd require parsing that text file. But just a thought! |
|
Implemented fetching the checksum from the |
Should close #42 Instead of downloading the nightly build to always the same folder `~/Library/Application\ Support/Zed/extensions/work/elixir/expert-nightly` which doesn't overwrite the existing installation since the `-nightly` suffix never changes, I use the checksum from the `expert_checksums.txt` file as a folder name - and therefore as a "version" which gets overwritten the next time a nightly release is pushed. I closed the previous PR #43 to move this to a feature branch
1 participant
Should close #42
Instead of downloading the nightly build to always the same folder
~/Library/Application\ Support/Zed/extensions/work/elixir/expert-nightlywhich doesn't overwrite the existing installation since the-nightlysuffix never changes, I download the file to a tmp folder, create its SHA256 checksum, and use the checksum as a folder name - and therefore as a "version" which gets overwritten the next time a nightly release is pushed.I have no clue whether that's the way to go, but it'd on my machine (well, the latest version of the nightly build didn't start, but that has nothing to do with this PR since it also fails on the official Elixir extension)