Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional path convenience methods #50

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Add additional path convenience methods #50

merged 1 commit into from
Apr 7, 2020

Conversation

paultyng
Copy link
Contributor

Add int/string helpers to the Index path convenience methods.

It would be kinda breaking, but may also be nice to change all of the convenience methods to be variadic? Maybe that's just overkill, UX wise you are probably only dealing with 1-2 depth at a time.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #50 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   70.28%   70.37%   +0.08%     
==========================================
  Files          79       79              
  Lines        7098     7106       +8     
==========================================
+ Hits         4989     5001      +12     
+ Misses       1666     1662       -4     
  Partials      443      443              
Impacted Files Coverage Δ
cty/path.go 75.75% <100.00%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5d9cf...4fc1f04. Read the comment docs.

@apparentlymart
Copy link
Collaborator

Thanks!

@apparentlymart apparentlymart merged commit e385b14 into zclconf:master Apr 7, 2020
@paultyng paultyng deleted the path-helpers branch April 8, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants