Backport fix for orphan handling #6928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
force-pushed
the
orphan-resolution
branch
from
93bb50a to
4e7ec7f
Compare
nuttycom
previously approved these changes
Aug 15, 2024
daira
force-pushed
the
orphan-resolution
branch
from
4e7ec7f to
f6de253
Compare
nuttycom
previously approved these changes
Aug 20, 2024
daira
force-pushed
the
orphan-resolution
branch
from
f6de253 to
34c6e76
Compare
nuttycom
previously approved these changes
Aug 21, 2024
(cherry picked from commit bitcoin/bitcoin@1b0bcc5) Zcash: Includes additional change to `IteratorComparator` cherry-picked from commit bitcoin/bitcoin@fbf327b.
always grow to its maximum size. This does not go so far as to attempt to connect orphans made connectable by a new block. Keeping the orphan map less full helps improve the reliability of relaying chains of transactions. (cherry picked from commit bitcoin/bitcoin@db0ffe8)
This prevents higher order orphans and other junk from holding positions in the orphan map. Parents delayed twenty minutes are more are unlikely to ever arrive. The freed space will improve the orphan matching success rate for other transactions. (cherry picked from commit bitcoin/bitcoin@11cc143)
…ted. An orphan whos parents were rejected is never going to connect, so there is little utility in keeping it. Orphans also helpfully tell us what we're missing, so go ahead and treat it as INVed. (cherry picked from commit bitcoin/bitcoin@8c99d1b) Zcash: Adapted to our INV changes.
Although this increases node memory usage in the worst case by perhaps 30MB, the current behavior causes severe issues with dependent tx relay. (cherry picked from commit bitcoin/bitcoin@54326a6)
(cherry picked from commit bitcoin/bitcoin@9453018) Zcash: Adapted to our codebase.
(cherry picked from commit bitcoin/bitcoin@6e051f3) Zcash: Adapted to us not having various upstream changes, including the orphan lock changes in bitcoin/bitcoin#11824.
This makes orphan processing work like handling getdata messages: After every actual transaction validation attempt, interrupt processing to deal with messages arriving from other peers. (cherry picked from commit bitcoin/bitcoin@866c805)
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
orphan-resolution
branch
from
34c6e76 to
c890bb5
Compare
|
Note that this passed required tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclosed in https://bitcoincore.org/en/2024/07/03/disclose-orphan-dos/
Includes commits cherry-picked from the following upstream PRs: