Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a Backend type for tests #1526

Closed
wants to merge 2 commits into from

Conversation

oxarbitrage
Copy link
Contributor

This is a draft of what i have in mind for the refactor part of #1412

An new enum type Backend was added to TestState replacing the db_data with a backend field where the inner database type can be retrieved by methods. This should allow tests to use the framework with a WalletDb or a MockWalletDb backend.

Before making more changes, it will be good to get some feedback to see if i am in a good track or if i should rethink it.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 77.08333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 61.08%. Comparing base (a1047ad) to head (2776454).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
zcash_client_sqlite/src/testing.rs 77.08% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
- Coverage   61.17%   61.08%   -0.09%     
==========================================
  Files         141      141              
  Lines       16645    16707      +62     
==========================================
+ Hits        10183    10206      +23     
- Misses       6462     6501      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom
Copy link
Contributor

nuttycom commented Sep 6, 2024

Closing in favor of #1530

@nuttycom nuttycom closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants