zfsbootmenu: look less bad on BIOS consoles #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FZF doesn't seem to handle
bright-colors on BIOS consoles; which--rawmode makes use of by setting non-matching lines to gray (dim) text. Since our color options are so limited and it would take revamping all of the colors just to make non-matching lines look reasonable in raw mode; lets just disable that for BIOS systems. If you're in the niche position where you access the ZBM over a serial console or SSH for a BIOS system, you don't get raw mode. Thems the breaks.This also sets the text color to magenta for lines that have been selected via tab, mostly used when selecting snapshots to diff.