Skip to content

fix: elimanate deprerated warnings #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

phanen
Copy link
Contributor

@phanen phanen commented Apr 14, 2025

No description provided.

@phanen phanen force-pushed the fix-deprecated-warnings branch from 319c517 to d46b4c7 Compare April 14, 2025 16:52
@AntoineGS
Copy link
Collaborator

This seems to have broken the plugin :)
https://github.com/AntoineGS/copilot.lua/actions/runs/14451766867/job/40525916887
I don't have access to the repo configs to add automated testing so I had to do it on my fork.
But they are all failing, the same happens when I run it on nvim 0.11 by checkout out the branch:
image

@phanen
Copy link
Contributor Author

phanen commented Apr 14, 2025

if fn.has("nvim-0.11") == 1 then

should be vim.fn

i am away from keyboard and i ll fix it tomorrow

@phanen phanen force-pushed the fix-deprecated-warnings branch from d46b4c7 to e6cb4c3 Compare April 15, 2025 05:25
@phanen phanen marked this pull request as draft April 15, 2025 05:42
@phanen phanen force-pushed the fix-deprecated-warnings branch from e6cb4c3 to 9be48ad Compare April 15, 2025 05:48
@phanen phanen marked this pull request as ready for review April 15, 2025 05:48
@phanen
Copy link
Contributor Author

phanen commented Apr 15, 2025

I test on 0.10.0/0.11.0, should work well now.

@AntoineGS AntoineGS merged commit 353853c into zbirenbaum:master Apr 15, 2025
1 check passed
@AntoineGS
Copy link
Collaborator

looking good :P

AntoineGS added a commit that referenced this pull request Apr 16, 2025
@AntoineGS
Copy link
Collaborator

I've had to revert the commit, as it was breaking the Copilot blink plugin #462
Feel free to open a new PR if you figure out how to resolve it, as support for 0.10 is still important.

@phanen
Copy link
Contributor Author

phanen commented Apr 16, 2025

ok i will see what i can do tomorrow

@phanen
Copy link
Contributor Author

phanen commented Apr 17, 2025

The revert can be reverted when giuxtaposition/blink-cmp-copilot#14 merged. (I create #464).

phanen added a commit to phanen/copilot.lua that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants