Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing files #2

Open
kajupe opened this issue Jul 29, 2024 · 12 comments
Open

Missing files #2

kajupe opened this issue Jul 29, 2024 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@kajupe
Copy link

kajupe commented Jul 29, 2024

Some files seem to be missing from this repo that makes the program not work, specifically the ones in the "checks" and "review" folders. When attempting to run it an error is met on line 22 of autoload.php (when it tries to load from "checks/pack.inc")
Making those files optional makes the program first-time-startup run but once out of that it fails.

@zbee
Copy link
Owner

zbee commented Jul 29, 2024

I won't be able to look at this until after Savages, but if you just make all of those checks/ and review/ files with nothing in them then it will likely become functional.

@zbee zbee added the bug Something isn't working label Jul 29, 2024
@zbee zbee self-assigned this Jul 29, 2024
@kajupe
Copy link
Author

kajupe commented Jul 29, 2024

Added files to no avail, it still sends "Failed to Parse" at the end of the setup. Enjoy savage!

@zbee
Copy link
Owner

zbee commented Jul 29, 2024

6ee15d6 probably fixed this, if you pull down changes.
cb6938c distinguishes two similar "Failed to Parse" messages.
90277ef should put the error into your browser's console.

If the error is not fixed can you please provide the error text on the web page and the error in your browser's console so that when I come back to this in a while I can have that ready?

@kajupe
Copy link
Author

kajupe commented Jul 29, 2024

Does not seem to be fixed, the error text on the web page is:
Failed to Parse (#setup)
The console logs:
Configured poses folder could not be found.

@zbee
Copy link
Owner

zbee commented Jul 29, 2024

This error only comes if your poses_folder from setup is not a folder, though, the default value for this is likely bad.
This could be a permissions issue with the software not being able to read what you set, or using the likely-bad default value.

If neither of these is the case, I'll have to replicate at a later date.
🤞🏻 fingers crossed though

@kajupe
Copy link
Author

kajupe commented Jul 29, 2024

Ok I must admit I completely missed the field where I had to specify the path so it did just look at the default value, didn't realize that was a field I should write in (my fault for skimming the setup too fast)
HOWEVER, there was another issue behind that it turns out, now instead of the Failed to Parse (#setup) error I get:

Warning: Undefined array key 0 in C:\xampp\htdocs\xiv-pose-organizer-master\logic\core\navigator.inc on line 47

Fatal error: Uncaught TypeError: navigator::current_pose(): Return value must be of type pose|int, null returned in C:\xampp\htdocs\xiv-pose-organizer-master\logic\core\navigator.inc:47 Stack trace: #0 C:\xampp\htdocs\xiv-pose-organizer-master\web\templates\work_through.php(6): navigator->current_pose() #1 C:\xampp\htdocs\xiv-pose-organizer-master\web\middleman.php(54): require('C:\xampp\htdocs...') #2 {main} thrown in C:\xampp\htdocs\xiv-pose-organizer-master\logic\core\navigator.inc on line 47

The folder I'm now pointing it to has .pose files aswell as folders and .txt files which I assume it filters out. Tried pointing it to a folder with only poses too and that caused the same error. If this is too different from the original topic I can open a new issue about this.

@zbee
Copy link
Owner

zbee commented Jul 29, 2024

Try deleting the contents of your /path/to/xiv-pose-organizer/web/data folder.
If you still get the same error after going through the setup step, I would request you zip and provide your whole data/ folder - I assume the folder parsing is getting very confused by something or is providing nothing at all.

@kajupe
Copy link
Author

kajupe commented Jul 29, 2024

The web folder did not have a "data" folder so I created an empty one. I also deleted the contents of the "xiv-pose-organizer/data" folder. Ran setup again after that with the same error. Attaching the data folder here
data.zip

@zbee
Copy link
Owner

zbee commented Jul 29, 2024

Right, the parser is providing nothing at all.
Can you also provide a screenshot of some of G:\FFXIV Poses, so I can see the sort of files and filenames I'm dealing with later on?

@kajupe
Copy link
Author

kajupe commented Jul 29, 2024

This is directly in G:\FFXIV Poses
image

This is inside the NyaNya collection (so there's actually poses)
image

Not much aside from these atm, I am working on reworking my pose library (hence why I found this program)

@zbee
Copy link
Owner

zbee commented Jul 29, 2024

Theoretically this should be totally supported.
Though I would not be surprised if folders existing without poses in them -such as .PoseImages/- was throwing it off; could be worth temporarily moving that folder out, deleting the contents of the data/ folders, and trying again.

I will look into the parser as soon as I can.

@kajupe
Copy link
Author

kajupe commented Jul 29, 2024

Unfortunately same issue without that folder. Thank you for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants