Enable usage of leaflet plugins #4289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the usage of leaflet plugins by accepting an additional argument to leaflet, which is as list of additional resources (.js and .css) to load after leaflet but before the map is created. A small example is included to demonstrate and test the functionality using the leaflet-rotatedmarker plugin.
falkoschindler
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Thanks for the pull request, @tfitzsim!
I just reviewed your code and made a few changes:
- We can move the example into an interactive demo on the documentation page.
- The JavaScript call can be replaced by calling
m.markerwith the rotation angle added to theoptionsdictionary. - The
additional_resourcesparameter was missing a description in the docstring. And we need to use theListtype from thetypingmodule for compatibility with Python 3.8. - The operation
additional_resources | []is invalid and needed to be replaced withadditional_resources or []. - The JavaScript call to
loadResourcescould be simplified.
Let's merge! 🙂
falkoschindler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the usage of leaflet plugins by accepting an additional argument to leaflet, which is as list of additional resources (.js and .css) to load after leaflet but before the map is created.
A small example is included to demonstrate and test the functionality using the leaflet-rotatedmarker plugin.
Feature request: #2767