Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify clearing of values in pytests with simulated user interaction #3750

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Simplify clearing of values in pytests with simulated user interaction #3750

merged 4 commits into from
Sep 26, 2024

Conversation

rodja
Copy link
Member

@rodja rodja commented Sep 19, 2024 •
edited
Loading

This PR implement the feature request from #3747 by introducing a clear method for the UserInteraction class. Usage:

user.find(ui.input).clear() # empties the content of an input element

@rodja rodja added the enhancement New feature or request label Sep 19, 2024
@rodja rodja added this to the 2.2 milestone Sep 19, 2024
MasterSergius
MasterSergius approved these changes Sep 19, 2024
View reviewed changes
Copy link

@MasterSergius MasterSergius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rodja rodja linked an issue Sep 22, 2024 that may be closed by this pull request
Testing: When typing to input field, validation is not triggered #3759
Closed
@falkoschindler falkoschindler removed a link to an issue Sep 24, 2024
Testing: When typing to input field, validation is not triggered #3759
Closed
@rodja rodja marked this pull request as ready for review September 24, 2024 17:43
@rodja @falkoschindler
clear with None instead of ''
ab67873 
Co-authored-by: Falko Schindler <falko@zauberzeug.com>
@rodja rodja merged commit c6d97df into main Sep 26, 2024
7 checks passed
@rodja rodja deleted the clear-values branch September 26, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkoschindler falkoschindler falkoschindler left review comments

@MasterSergius MasterSergius MasterSergius approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rodja @MasterSergius @falkoschindler