-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation and type-hinting to base element class. #356
Conversation
Note, some of the changes are artifacts of running the "black" formatting tool before submitting my code. |
Thanks a lot for this pull request, @washad!
You also started to improve type-hinting, which is somewhat independent of the documentation and might deserve its own PR with its own dedicated space for discussion. But here are my thoughts so far:
Long story short: Let's concentrate on documentation and fix the formatting differences. |
I'll try to have an update this weekend : ) |
I've made the requested changes, lemme know : ) |
Thanks, @washad! |
No description provided.