Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when storage_secret is missing #2445

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Conversation

rodja
Copy link
Member

@rodja rodja commented Jan 26, 2024

This PR fixes #2438.

@rodja rodja added the bug Something isn't working label Jan 26, 2024
@rodja rodja added this to the 1.4.13 milestone Jan 26, 2024
@rodja rodja requested a review from falkoschindler January 26, 2024 15:37
@rodja rodja marked this pull request as draft January 26, 2024 15:42
@falkoschindler falkoschindler marked this pull request as ready for review January 27, 2024 15:20
Copy link
Contributor

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodja I improved the implementation a little. What do you think?

@rodja
Copy link
Member Author

rodja commented Jan 27, 2024

Great! Let's merge!

@falkoschindler falkoschindler merged commit ca78160 into main Jan 27, 2024
7 checks passed
@falkoschindler falkoschindler deleted the storage_error branch January 27, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthMiddleware leads to startup error when no storage_secret is set
2 participants