Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow handling Mermaid errors on the server #2396

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Allow handling Mermaid errors on the server #2396

merged 1 commit into from
Jan 18, 2024

Conversation

falkoschindler
Copy link
Contributor

As discussed in #2390, this PR allows to subscribe to Mermaid errors.

ui.mermaid('''
graph LR;
    A --> B;
    A -> C;
''').on('error', lambda e: ui.label(e.args['message']))

Screenshot 2024-01-18 at 10 03 51

@falkoschindler falkoschindler requested a review from rodja January 18, 2024 09:04
@falkoschindler falkoschindler added the enhancement New feature or request label Jan 18, 2024
@falkoschindler falkoschindler added this to the 1.4.11 milestone Jan 18, 2024
rodja
rodja approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@rodja rodja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@falkoschindler falkoschindler merged commit 249810f into main Jan 18, 2024
7 checks passed
@falkoschindler falkoschindler deleted the mermaid-errors branch January 18, 2024 13:29
@rodja rodja modified the milestones: 1.4.11, 1.4.12 Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodja rodja rodja approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.12
Development

Successfully merging this pull request may close these issues.
2 participants
@falkoschindler @rodja