#288 fix log.push for lines containing line breaks

zauberzeug · Jan 24, 2023 · 988285a · 988285a
1 parent dfa7929
commit 988285a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/nicegui/elements/log.py b/nicegui/elements/log.py
@@ -24,6 +24,6 @@ def __init__(self, max_lines: Optional[int] = None) -> None:
         self.lines: deque[str] = deque(maxlen=max_lines)
 
     def push(self, line: str) -> None:
-        self.lines.append(line)
+        self.lines.extend(line.splitlines())
         self._props['lines'] = '\n'.join(self.lines)
         self.run_method('push', line)
diff --git a/tests/test_log.py b/tests/test_log.py
@@ -1,3 +1,5 @@
+from selenium.webdriver.common.by import By
+
 from nicegui import ui
 
 from .screen import Screen
@@ -11,7 +13,14 @@ def test_log(screen: Screen):
     log.push('D')
 
     screen.open('/')
-    screen.should_not_contain('A')
-    screen.should_contain('B')
-    screen.should_contain('C')
-    screen.should_contain('D')
+    assert screen.selenium.find_element(By.ID, log.id).text == 'B\nC\nD'
+
+
+def test_log_with_newlines(screen: Screen):
+    log = ui.log(max_lines=3)
+    log.push('A')
+    log.push('B')
+    log.push('C\nD')
+
+    screen.open('/')
+    assert screen.selenium.find_element(By.ID, log.id).text == 'B\nC\nD'